[ofa-general] Re: [PATCH v2 2/4] rdma/cma: simplify locking neededfor serialization of callbacks

Roland Dreier rdreier at cisco.com
Tue Jul 8 11:58:28 PDT 2008


 > Personally, I'm fine either way.  This method can acquire/release the mutex
 > twice, though that's not a big deal.  If we want better encapsulation, we could
 > also add a cma_enable_callback wrapper around the mutex_unlock.

I was thinking about that enable wrapper too... might make everything
easier to read.

(I think the double mutex in some cases is totally negligible, and the
clearer source more than makes up for it)



More information about the general mailing list