[ofa-general] Re: [PATCH] mlx4_core: add module parameter to enable/disable QoS support. (for 2.6.27)

[Roland Dreier]

thanks, applied... a few comments:

 > Subject: [PATCH] mlx4_core: add module parameter to enable/disable QoS support. (for 2.6.27)

please put the (for 2.6.27) inside the [] with "PATCH" so that it gets
automatically stripped.  As it is I have to edit this out by hand.

 > Content-Transfer-Encoding: quoted-printable

argh... the patch ends up looking like:

 > =2D-- a/drivers/net/mlx4/fw.c
 > +++ b/drivers/net/mlx4/fw.c
 > @@ -46,6 +46,10 @@ enum {
 >  extern void __buggy_use_of_MLX4_GET(void);
 > extern void __buggy_use_of_MLX4_PUT(void);
 > =20

and I have to fix that by hand too.

 > From 01d8c13b6dd314b239a5b0b76e57320aeaa5c338 Mon Sep 17 00:00:00 2001

please leave that header out too... I have to edit *that* out by hand
as well.

 > +static int mlx4_core_enable_qos;
 > +module_param_named(enable_qos, mlx4_core_enable_qos, int, 0444);

given that it's static, why not just

static int enable_qos;
module_param(enable_qos, bool, 0444);

(and make it a "bool" too, since we just want on/off)

 - R.