[ofa-general] RE: [PATCH] CMA: Notify ULP when CM exits TIMEWAIT - interaction with the addr change event

Or Gerlitz ogerlitz at voltaire.com
Wed Jul 16 02:44:44 PDT 2008


Sean Hefty wrote:
> Roland, this obviously isn't critical, but it would be nice to get into 2.6.27
> if possible, to include it in the next release of the librdmacm.
>> --- a/include/rdma/rdma_cm.h
>> +++ b/include/rdma/rdma_cm.h
>> @@ -57,7 +57,8 @@ enum rdma_cm_event_type {
>> 	RDMA_CM_EVENT_DISCONNECTED,
>> 	RDMA_CM_EVENT_DEVICE_REMOVAL,
>> 	RDMA_CM_EVENT_MULTICAST_JOIN,
>> -	RDMA_CM_EVENT_MULTICAST_ERROR
>> +	RDMA_CM_EVENT_MULTICAST_ERROR,
>> +	RDMA_CM_EVENT_TIMWAIT_EXIT
>> };
librdmacm has already the address change event being the next in the 
enum after the multicast error event, so merging this patch to the 
kernel before the address change one will make the rdma cm event enums 
different between user and kernel.

Roland, would it be possible to apply this patch on top of the address 
change one? I have checked and Linus has not merged yet the bonding 
patch that allows the rdmacm addr change patch to get compiled, so its 
going to take few more days, I guess.

Or.




More information about the general mailing list