[ofa-general] [PATCH 3/3] ib/uverbs: add support for create_qp_expanded in uverbs

[Jack Morgenstein]

In general, this should be written so that ib_uverbs_create_qp invokes a helper function
which does work both for ib_uverbs_create_qp and ib_uverbs_create_qp_expanded.
(ib_uverbs_create_qp() is only needed to support older libibverbs/libmlx4 libraries.
The new library will do create-qp via create-qp-expanded, with create-flags = 0).

- Jack

On Sunday 20 July 2008 22:16, Ron Livne wrote:
> @@ -705,8 +699,7 @@ struct ib_qp *mlx4_ib_create_qp(struct ib_pd *pd,
>  					IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK))
>  		return ERR_PTR(-EINVAL);
> 
> -	if (init_attr->create_flags &&
> -	    (pd->uobject || init_attr->qp_type != IB_QPT_UD))
> +	if (init_attr->create_flags && init_attr->qp_type != IB_QPT_UD)
>  		return ERR_PTR(-EINVAL);
You have opened the door here for userspace to set IB_QP_CREATE_IPOIB_UD_LSO
This is incorrect. Please fix.
>