[ofa-general] Re: [PATCH 1/7] drivers/infiniband: Release mutex in error handling code

Hoang-Nam Nguyen HNGUYEN at de.ibm.com
Mon Jul 21 11:28:59 PDT 2008


Roland and Julia,
Looks good to me. Thanks for pointing this out.
Nam

Roland Dreier <rdreier at cisco.com> wrote on 21.07.2008 18:25:07:

>  > --- a/drivers/infiniband/hw/ehca/ipz_pt_fn.c
>  > +++ b/drivers/infiniband/hw/ehca/ipz_pt_fn.c
>  > @@ -163,6 +163,7 @@ static int alloc_small_queue_page(struct
>  >
>  >  out:
>  >     ehca_err(pd->ib_pd.device, "failed to allocate small queue page");
>  > +   mutex_unlock(&pd->lock);
>  >     return 0;
>  >  }
>
> Thanks, looks obviously correct.  ehca guys, I will queue this for my
> next pull request to Linus; please let me know if you see a problem and
> want me to drop it.
>
>  - R.




More information about the general mailing list