[ofa-general] RE: [PATCH] core/iwcm: remove IB_ACCESS_LOCAL_WRITE in remote QP attributes

[Chien Tung]

> From: Roland Dreier [mailto:rdreier at cisco.com] 

> This nes code looks really strange:
> 
> 	if (attr_mask & IB_QP_ACCESS_FLAGS) {
> 		if (attr->qp_access_flags & IB_ACCESS_LOCAL_WRITE) {
> 			nesqp->nesqp_context->misc |= 
> cpu_to_le32(NES_QPCONTEXT_MISC_RDMA_WRITE_EN |
> 					
> NES_QPCONTEXT_MISC_RDMA_READ_EN);
> 			issue_modify_qp = 1;
> 		}

This one maybe a workaround for a silicon bug.  I have to look 
into it to be sure.

> 		if (nesqp->user_mode) {
> 			nesqp->nesqp_context->misc |= 
> cpu_to_le32(NES_QPCONTEXT_MISC_RDMA_WRITE_EN |
> 					
> NES_QPCONTEXT_MISC_RDMA_READ_EN);
> 			issue_modify_qp = 1;
> 		}
> 	}

> I don't see why setting LOCAL_WRITE should imply both RDMA 
> permissions, or why you always want to set those permissions 
> for usermode QPs ??

There is a comment in our CVS source indicating that was a 
workaround for a CM bug in OFED 1.2.  We may be able to remove this one.

Chien