[ofa-general][RFC] IPv6 support for RDMA CM

Roland Dreier rdreier at cisco.com
Wed Jul 30 09:48:53 PDT 2008


haven't looked in detail, but a couple quick comments:

 >  	struct sockaddr src_addr;
 > +	u8 src_pad[sizeof(struct sockaddr_in6) - sizeof(struct sockaddr)];

Rather than doing this (which is rather fragile in addition to being
ugly), just use struct sockaddr_storage.

Yes the existing CMA code should get the same treatment.

 > --- a/net/ipv6/ndisc.c
 > +++ b/net/ipv6/ndisc.c
 > @@ -156,6 +156,7 @@ struct neigh_table nd_tbl = {
 >  	.gc_thresh2 =	 512,
 >  	.gc_thresh3 =	1024,
 >  };
 > +EXPORT_SYMBOL(nd_tbl);

Rather than exporting nd_tbl I think it would make more sense to
uninline ndisc_get_neigh() and export that.

I suggest starting a discussion about this on netdev at vger.kernel.org --
explain the rationale of wanting to do IPv6 neighbour discovery from a
module and post this patch including the part that exports the needed
core symbols.

 - R.



More information about the general mailing list