[ofa-general] Re: [PATCH] OpenSM/osm_sa_mcmember_record.c: Validate some more MGID bits for IPv6 SNM

[Hal Rosenstock]

On Mon, 2008-06-02 at 22:51 +0300, Sasha Khapyorsky wrote:
> On 07:00 Mon 02 Jun     , Hal Rosenstock wrote:
> > OpenSM/osm_sa_mcmember_record.c: Include high order 24 bits of low 64
> > MGID bits in validation as these bits are supposed to be 0
> > 
> > Signed-off-by: Hal Rosenstock <hal at xsigo.com>
> > 
> > diff --git a/opensm/opensm/osm_sa_mcmember_record.c b/opensm/opensm/osm_sa_mcmember_record.c
> > index c14632d..73b3fc4 100644
> > --- a/opensm/opensm/osm_sa_mcmember_record.c
> > +++ b/opensm/opensm/osm_sa_mcmember_record.c
> > @@ -1088,14 +1088,15 @@ __search_mgrp_by_mgid(IN cl_map_item_t * const p_map_item, IN void *context)
> >  			 * YYYYYY is the last 24 bits of the port guid */
> >  #define PREFIX_MASK (0xff10ffff0000ffffULL)
> >  #define PREFIX_SIGNATURE (0xff10601b00000000ULL)
> > -#define INT_ID_MASK (0x00000001ff000000ULL)
> > +#define INT_ID_MASK (0xffffff1ff000000ULL)
> 
> Should be 
> 
>   #define INT_ID_MASK (0xfffffff1ff000000ULL)
> 
> (one more 'f' at begining), right?

Yes.

-- Hal

> 
> Sasha
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general