[ofa-general][PATCH 8/12 v1] mlx4: Dynamic port configuration

[Yevgeny Petrilin]

Roland Dreier wrote:

> If I read the code correctly, there is no locking around this, so
> multiple processes could race and cause all sorts of problems.  

I will add locking in the "mlx4_change_port_types" function and re-submit the patch.

> And also you do the assignment
> 
>  > +			dev->caps.port_type[i + 1] = port_types[i];
> 
> before unregistering the device -- so there is a window where
> caps.port_type has the wrong data -- not sure if this is a real issue.
> 
If the port type changes, we unregister and then register the device, so I don't think
that the temporary wrong data in caps.port_type has any influence.

Thanks,
Yevgeny


--
Yevgeny Petrilin
Mellanox Technalogies LTD.
SW- Linux
Phone: +972 (4) 909 7200 (ext.7677)
Mobile: +972 (54) 783 9222
E-mail: yevgenyp at mellanox.co.il

----------------------------------------------------------------------
Emails belong on computers, trees belong in forests; if you must print
this, do it on recycled paper.
http://www.greenpeace.org/international/
----------------------------------------------------------------------


Disclaimer added by CodeTwo Exchange Rules
http://www.codetwo.com