[ofa-general] Re: [PATCH 0/2] Prevent loss of interrupts in IB/ehca

[Paul Mackerras]

Stefan Roscher writes:

> The processing of events with a timer controlled polling is not the "typical"
> way how you should handle adapter events.

Do you mean it's not typical in Linux (I would have said it was), or
it's not the way that the firmware architects and implementers thought
the eHEA hcalls would be used?

> During corner case testing, we noticed that some versions of ehca 
> do not properly transition to interrupt done in special load situations.
> This can be resolved by periodically triggering EOI through H_EOI, 
> if eqes are pending.

So in other words, doing the extra EOIs is a workaround for a firmware
and/or hardware bug, then?  If that's the case then you needed to say
that in the commit message.

Given that the ehea driver does hcalls itself directly, and this is a
workaround for a firmware/hardware bug, it may actually be cleaner
just to have the ehea driver do the necessary H_EOI calls directly.

Paul.