[ofa-general] Re: [PATCH v4 04/14] QLogic VNIC: Implementation of Control path of communication protocol

[Stephen Hemminger]

On Tue, 10 Jun 2008 17:04:15 -0400
Ramachandra K <ramachandra.kuchimanchi at qlogic.com> wrote:

> +#ifdef CONFIG_INFINIBAND_QLGC_VNIC_STATS
> +	struct {
> +		cycles_t	request_time;	/* intermediate value */
> +		cycles_t	response_time;
> +		u32		response_num;
> +		cycles_t	response_max;
> +		cycles_t	response_min;
> +		u32		timeout_num;
> +	} statistics;

Shouldn't you be using ktime_t rather than cycles_t? And then convert
it to some standard time base (ns, ms, or USER_HZ) when reporting
to user space.