[ofa-general] Re: [PATCH v4 14/14] QLogic VNIC: sysfs Documentation

[Patrick McHardy]

Amar Mudrankit wrote:
> I have just started on getting into the rtnl_link API.  There are few
> queries on it, plz correct me if I am wrong.
> 
> 1.  If I understand it correctly, this interface is not text based.
> Hence, it looks like this interface needs a separate user program
> which actually sends the parameters to the driver. A separate user
> program for each driver, as their configuration parameters might be
> different. Is it right?

Not necessarily an entire program, you can integrate it in
iproute2 or libnl. Look at ip/iplink_vlan.c in iproute for
an example.

> 2.  I am not sure if there exists a standardized (netlink?) interface
> through which parameters can be passed to kernel.

For virtual network drivers, its rtnl_link, or more generally,
rtnetlink.

> If so, there would
> be standard set of parameters that can be configured and standard set
> of statistics values that can be retrieved from driver. Is it so?

Yes.

> Actually, I tried googling around rtnl_link, but couldn't collect
> sufficient information.
> 
> 3.  Is there any kind of documentation available on this? I tried
> searching on it in Documentation/ directory as well as git log but
> could not locate enough of it.

My fault, I have some unfinished documentation that I never
completed. There are a few examples in the tree:

drivers/net/dummy.c
drivers/net/macvlan.c
drivers/net/ifb.c
drivers/net/veth.c
net/8021q/vlan_netlink.c

macvlan and vlan are probably best suited as an example, dummy
and ifb are too simple and veth is kind of special because it
registers two devices.

If you have questions, feel free to ask.

> 4.  Can anybody point to an ethernet driver as an example of
> implementation of rtnl_link API along with an equivalent user space
> program to configure it?
> 
> That would be of immense help.

See above.

>>> +echo -n 00066a01de000037              >
>>> /sys/class/infiniband_qlgc_vnic/interfaces/veth1/primary_path/ioc_guid
>>> +echo -n fe8000000000000100066a11de000037 >
>>> /sys/class/infiniband_qlgc_vnic/interfaces/veth1/primary_path/dgid
>>> +echo -n ffff                                  >
>>> /sys/class/infiniband_qlgc_vnic/interfaces/veth1/primary_path/pkey
>> I guess life would be easier for users if those parameters can
>> be generated in userspace or at least looked up in something
>> like the maps in /etc/iproute2/.
>>
> 
> Is it the answer of question no 2 above? If so, what about statistics
> of the driver then?

You can dump driver private statistics in the ->fill_xstats function.

>> In any case, things like tx_csum and rx_csum definitely do
>> not belong in this interface.
>>
> 
> We are planning to give ethtool support for the driver in future, in
> which case these 2 parameters will be configured through ethtool.

Yes, thats where it belongs.