[ofa-general] Re: IB/ipoib: no need to call skb_orphan() in cm_send()?

[Eli Cohen]

On Mon, 2008-06-02 at 21:01 +0200, Hoang-Nam Nguyen wrote:
> Hello Eli!
> I'm referring to the thread below, where you explained the rational of
> calling skb_orphan() after post_send() in UD path:
> [ewg] Re: [PATCH] call skb_orphan() after sending an SKB
> http://lists.openfabrics.org/pipermail/ewg/2008-February/005739.html
> 
> Looking at cm_send path I don't see that call. Is there any reason not to
> do that here?
> 

Hi Nam,

sorry I did not respond - your email somehow slid and I did not see it.
There are two reason why I use skb_orphan for UD mode:
1. I poll the CQ once in 16 posts
2. I do not arm the CQ
This may lead to a situation where it takes some time before the SKB is
released and the socket might be sensitive to this (ICMP for example).

In CM mode, the sender is CQ is interrupt driven so the SKB will be
freed quite soon after it was posted so problem does not occur.

I hope that answers your question.