[ofa-general] Re: [PATCH v4 14/14] QLogic VNIC: sysfs Documentation

[Patrick McHardy]

Ramachandra K wrote:
> Is your suggestion that the netdevice needs to be registered as soon
> as we get parameters from userspace even if that netdevice stays
> inactive until we finish all of our communication with the QLogic EVIC
> gateway device over the IB network ?

Yes, it should be created as soon as the administrator
issues the command to do so.

> Currently we register netdevice only after we have made sure that we
> can connect to the EVIC and that there are enough resources on the
> EVIC to support this virtual ethernet interface. But if we register
> the netdevice
> without making sure that we can reach the EVIC and that it has resources,
> there is a possibility that we register a netdevice that can never
> become active.

Thats similar to a ethernet device that never has a cable
plugged in. You should register the device with its carrier
turned off, then change the carrier state once the connection
has been established.

> Isn't our current behavior analogous to an ethernet driver not
> registering a netdev if it
> can't properly initialize its hardware ?

No, hardware probing is done automatically, while with your
device the administrator explicitly asks to create the device.
The expected behaviour is that the device exists once the
command finishes without returning an error.