[ofa-general] [PATCH RFCv2 2/2] RDMA/cxgb3: Add support for protocol statistics.

Steve Wise swise at opengridcomputing.com
Wed Jun 18 14:05:14 PDT 2008


Roland Dreier wrote:
>  > +	stats->iw.ipInReceive = m.ipInReceive_hi + m.ipInReceive_lo;
>
> Surely all the code like this is wrong?  Shouldn't it be more like
>
> 	stats->iw.ipInReceive = ((u64) m.ipInReceive_hi << 32) +
> 		m.ipInReceive_lo;
>
>  - R.
>   
Hrrrm,

I would think so!

Steve.






More information about the general mailing list