[ofa-general] [PATCH RFC] RDMA/cxgb3: MEM_MGT_EXTENSIONS support

[Steve Wise]

Roland Dreier wrote:
> Thanks, applied, with one minor fix:
>
>  > +static int fw_supports_fastreg(struct iwch_dev *iwch_dev)
>
> ...
>
>  > +	return (fw_maj >= 6 && fw_min > 0);
>
> You really mean
>
> 	return fw_maj > 6 || (fw_maj == 6 && fw_min > 0);
>
> right?
>
>   
yes.

> and also I changed the 'p' pointer to __be64 in iwch_build_fastreg(),
> but that still leaves
>
>     drivers/infiniband/hw/cxgb3/iwch_qp.c:174:6: warning: incorrect type in assignment (different base types)
>     drivers/infiniband/hw/cxgb3/iwch_qp.c:174:6: expected restricted unsigned long long [usertype] *[assigned] p
>     drivers/infiniband/hw/cxgb3/iwch_qp.c:174:6: got unsigned long long *
>
> for the line
>
> 			p = &wqe->flit[1];
>
> because flit[] is u64.  What's the best way to fix this?
>
>   

I think flit[] should be __be64.