[ofa-general] Re: [PATCH 8/11] core: XRC receive-only QPs

[Roland Dreier]

 > +struct ib_uverbs_create_xrc_rcv_qp {
 > +	__u64 response;
 > +	__u64 user_handle;
 > +	__u32 xrc_domain_handle;
 > +	__u32 max_send_wr;
 > +	__u32 max_recv_wr;
 > +	__u32 max_send_sge;
 > +	__u32 max_recv_sge;
 > +	__u32 max_inline_data;
 > +	__u8  sq_sig_all;
 > +	__u8  qp_type;
 > +	__u8  reserved[2];
 > +	__u64 driver_data[0];
 > +};

same alignment problem -- reserved needs to be [6] not [2] to keep the
alignment of driver_data constant.

 > +struct ib_uverbs_modify_xrc_rcv_qp {
 > +	__u32 xrc_domain_handle;
 > +	__u32 qp_num;
 > +	struct ib_uverbs_qp_dest dest;
 > +	struct ib_uverbs_qp_dest alt_dest;
 > +	__u32 attr_mask;
 > +	__u32 qkey;
 > +	__u32 rq_psn;
 > +	__u32 sq_psn;
 > +	__u32 dest_qp_num;
 > +	__u32 qp_access_flags;
 > +	__u16 pkey_index;
 > +	__u16 alt_pkey_index;
 > +	__u8  qp_state;
 > +	__u8  cur_qp_state;
 > +	__u8  path_mtu;
 > +	__u8  path_mig_state;
 > +	__u8  en_sqd_async_notify;
 > +	__u8  max_rd_atomic;
 > +	__u8  max_dest_rd_atomic;
 > +	__u8  min_rnr_timer;
 > +	__u8  port_num;
 > +	__u8  timeout;
 > +	__u8  retry_cnt;
 > +	__u8  rnr_retry;
 > +	__u8  alt_port_num;
 > +	__u8  alt_timeout;
 > +	__u8  reserved[2];
 > +	__u64 driver_data[0];
 > +};

ditto

 > +struct ib_uverbs_query_xrc_rcv_qp {
 > +	__u64 response;
 > +	__u32 xrc_domain_handle;
 > +	__u32 qp_num;
 > +	__u32 attr_mask;
 > +	__u64 driver_data[0];
 > +};

needs

	__u32 reserved;

after attr_mask.

 - R.