[ofa-general] Re: [PATCH] IPOIB: add LRO support.
Roland Dreier
rdreier at cisco.com
Mon Jun 23 14:43:18 PDT 2008
Overall, looks mostly fine (although as I've said a lot of times today,
please run scripts/checkpatch.pl and look at the output before sending
patches -- it saves lots of time for everyone).
One question -- given this:
> + if (skb->protocol != htons(ETH_P_IP))
> + return -1;
is there any way we could have anything other than IPv4 here:
> + if (iph->protocol != IPPROTO_TCP || iph->version != 4)
> + return -1;
- R.
More information about the general
mailing list