[ofa-general] [PATCH v1 for-2.6.27] IPOIB: add LRO support

Vladimir Sokolovsky vlad at dev.mellanox.co.il
Tue Jun 24 05:07:24 PDT 2008


Or Gerlitz wrote:
> Vladimir Sokolovsky wrote:
>> add "ipoib_use_lro" module parameter to enable LRO.
> How about that for this one we'll go on a finer granularity of being 
> able to set it per device through sysfs?

Yes, we thought about this  and I am planning to add this granularity
later, in a different patch.

> 
>> +    priv->lro.lro_mgr.get_skb_header = get_skb_hdr;
>> +    priv->lro.lro_mgr.ip_summed = CHECKSUM_UNNECESSARY;
>> +    priv->lro.lro_mgr.ip_summed_aggr = CHECKSUM_UNNECESSARY;
> Looking in _lro_proc_skb() which is the code that would be processing 
> ipoib skbs, it seems that the values of lro_mgr.ip_summed and 
> lro_mgr.ip_summed_aggr should correlate to whether the HCA is capable of 
> doing checksum offload or not.
> 
> Or.
> 


+static int get_skb_hdr(struct sk_buff *skb, void **iphdr,
+               void **tcph, u64 *hdr_flags, void *priv)
+{

...

+
+    if (unlikely(skb->ip_summed != CHECKSUM_UNNECESSARY))
+        return -1;

This will return -1 if HCA is not capable of doing checksum offload.

Regards,
Vladimir





More information about the general mailing list