***SPAM*** Re: [ofa-general] Re: [PATCH 2/3 v2] mlx4: multicast cast loopback block

[Or Gerlitz]

Roland Dreier wrote:
> Please run your patches through scripts/checkpatch.pl and consider the output before sending them... it's easy to do and saves everyone time fixing trivial style mistakes.
Roland,

Ron will be here later this week and then he can make the check and resend.
> Am I missing something?  Is there a reason not to write this as:
>
> 	return mlx4_multicast_attach(to_mdev(ibqp->device)->dev,
> 				     &to_mqp(ibqp)->mqp, gid->raw,
> 				     !!(to_mqp(ibqp)->flags & MLX4_IB_QP_BLOCK_LOOPBACK));
personally, I find !! code somehow hard to read, but if this is the 
common practice in such cases, we can fix that...

Or.