[ofa-general] ***SPAM*** [PATCH 3/3 v3] ib/ipoib: blocking multicast loopback ipoib packets
Roland Dreier
rdreier at cisco.com
Fri Jun 27 21:41:18 PDT 2008
> > + .create_flags = 0
> Why do you need to set create_flags explicitly?
right, that's redundant, since missing initializer fields are always
cleared to 0.
> > - init_attr.create_flags = IB_QP_CREATE_IPOIB_UD_LSO;
> > + init_attr.create_flags |= IB_QP_CREATE_IPOIB_UD_LSO;
> and change this too?
this doesn't seem that bad a change to me. It is defensive against
later changes adding something else to create_flags earlier on in the
function, and it is also nice to be uniform with the block loopback
flag. So I'll leave this in.
- R.
More information about the general
mailing list