[ofa-general] [PATCH RFC] RDMA/cxgb3: Fixes for zero-stag.

Roland Dreier rdreier at cisco.com
Sat Jun 28 08:18:41 PDT 2008


a couple cleanups you can do:

 > +	if (!pbl_addr) {
 > +		return -ENOMEM;
 > +	}

{ } not needed for single-line "then" clause.

 > +			cxio_hal_pblpool_free(wq->rdev, wq->rq[Q_PTR2IDX(wq->rq_rptr, wq->rq_size_log2)].pbl_addr, T3_STAG0_PBL_SIZE);

this line is a bit long, even for me.  It's easy to break at the ','



More information about the general mailing list