[ofa-general] [PATCH v3 for-2.6.27] IPOIB: add LRO support.

[Or Gerlitz]

Eli Cohen wrote:
> We agree that you can't link an SKB unless you know its checksum is correct, right? So I suggest that we just add a comment here saying something like this:
>
>      /* in the future we may add an else cluase that verifies the
>       * checksum and allows devices which do not calculate checksum
>       * to use LRO */
> +    if (unlikely(skb->ip_summed != CHECKSUM_UNNECESSARY))
> +            return -1;
OK, fair enough.
> We still want to have the default value being controlled by a module parameter.
"we still want X to happen" does not justify including code... please 
make an argument why you want X to happen and what you think is the 
correct  method Y to make X happen.

Or.