[ofa-general] Re: [PATCH REPOST RFCv2 1/2] RDMA/Core: Add local dma lkey support.
Roland Dreier
rdreier at cisco.com
Mon Jun 30 13:18:51 PDT 2008
> --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c
> + dev->ibdev.local_dma_lkey = 0;
why this specific initialization but not in nes or amso1100? I think
the device structure is zeroed out on allocation anyway.
> __be64 node_guid;
> u8 node_type;
> u8 phys_port_cnt;
> + u32 local_dma_lkey;
It's a little silly of me to mention this, given how few of these
structures are used, but I think it would be nicer to put local_dma_lkey
after node_guid to avoid leaving padding in the structure.
- R.
More information about the general
mailing list