[ofa-general] [PATCH] IB/IPoIB: Fix change mtu when switching to UD mode
Or Gerlitz
ogerlitz at voltaire.com
Mon Jun 30 23:28:44 PDT 2008
Eli Cohen wrote:
>
> use the kernel function dev_set_mtu() instead of directly setting dev->mtu. This is necessary so any other subsystem that need to know about this will (this is done through the call to call_netdevice_notifiers().
Please note that a flow which invokes call_netdevice_notifiers() should
be wrapped by rtnl_lock()/rtnl_unlock() and the context should be made
sleepable /non-atomic, etc the the consumers of this event might go to
sleep (eg on memory allocation for the skb of the netlink event to user
space etc).
Eli, yes, using dev_set_mtu() seems the correct way to go, even though I
don't think it explains any of the ipoib problems I have came across
over the last days, which I reported to you on the list, so in that
respect I don't really understand your other email where you have
pointed to me the mtu/setting issue.
Or.
More information about the general
mailing list