[ofa-general] Re: [RFC PATCH 05/14] RFC RDMA/cxgb3: IDR IDs are signed

Steve Wise swise at opengridcomputing.com
Tue Mar 4 08:27:55 PST 2008


Acked-by: Steve Wise <swise at opengridcomputing.com>

Roland Dreier wrote:
> Fix sparse warnings about pointer signedness by using a signed int when
> calling idr_get_new_above().
> 
> Signed-off-by: Roland Dreier <rolandd at cisco.com>
> ---
>  drivers/infiniband/hw/cxgb3/iwch.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb3/iwch.h b/drivers/infiniband/hw/cxgb3/iwch.h
> index caf4e60..9ad9b1e 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch.h
> +++ b/drivers/infiniband/hw/cxgb3/iwch.h
> @@ -147,7 +147,7 @@ static inline int insert_handle(struct iwch_dev *rhp, struct idr *idr,
>  				void *handle, u32 id)
>  {
>  	int ret;
> -	u32 newid;
> +	int newid;
>  
>  	do {
>  		if (!idr_pre_get(idr, GFP_KERNEL)) {




More information about the general mailing list