[ofa-general] Re: [PATCH] IB/mlx4: Add checksum offload support

[Or Gerlitz]

Roland Dreier wrote:
> thanks, I applied the ipoib and mlx4 patches with some cleanups.
> One thing I changed is that ipoib doesn't keep a cached copy of the
> HCA capabilities flags -- I didn't see any reason why it was needed.
>   
Such a copy would make the patches for LSO and interrupt moderation 
support simpler. If we agree on this point, it could be added through 
the patch set for those two features, which in the light of the 
integration these two patches, should be on its way (Eli? also the mthca 
checksum offload patch).
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -1120,6 +1121,25 @@ static struct net_device *ipoib_add_port(const char *format,
>  		goto device_init_failed;
>  	}
> .... 
> +	if (device_attr->device_cap_flags & IB_DEVICE_UD_IP_CSUM) {
> +		set_bit(IPOIB_FLAG_CSUM, &priv->flags);
> +		priv->dev->features |= NETIF_F_SG | NETIF_F_IP_CSUM;
> +	}
>   
Don't you need to check the mode (connected vs datagram) of the device 
at this point before advertising these the S/G and CSUM flags to the stack?

Or.