[ofa-general] Re: [PATCH] IB/mlx4: Add checksum offload support

[Roland Dreier]

 > Such a copy would make the patches for LSO and interrupt moderation
 > support simpler. If we agree on this point, it could be added through
 > the patch set for those two features, which in the light of the
 > integration these two patches, should be on its way 

Yes that would be fine.  In the context of the checksum offload patch
alone having the hca_caps member added nothing but complexity so I
just got rid of it.

 > > .... +	if (device_attr->device_cap_flags &
 > > IB_DEVICE_UD_IP_CSUM) {
 > > +		set_bit(IPOIB_FLAG_CSUM, &priv->flags);
 > > +		priv->dev->features |= NETIF_F_SG | NETIF_F_IP_CSUM;
 > > +	}
 > >
 > Don't you need to check the mode (connected vs datagram) of the device
 > at this point before advertising these the S/G and CSUM flags to the
 > stack?

This is before we even do register_netdev so we know the device is in
datagram mode.

 - R.