> I believe we still have a problem if don't set the pointer to NULL. If > one of the subsequent operations fails we will end up freeing the same > pointer twice. Oops, thanks. I got rid of the tricky NULL stuff and just freed device_attr in the three places where it matters.