[ofa-general] [PATCH 01/10] IB/ipath - fix a byte order compile check warning

Ralph Campbell ralph.campbell at qlogic.com
Fri Mar 21 10:05:27 PDT 2008


On Fri, 2008-03-21 at 09:54 -0700, Roland Dreier wrote:
>  > This patch fixes a compiler warning when the driver is compiled with:
>  > make M=drivers/infiniband/hw/ipath C=2 CF=-D__CHECK_ENDIAN__
> 
>  > -		dd->ipath_pioavailregs_dma[i] = dd->ipath_pioavailshadow[i]
>  > -			= le64_to_cpu(val);
>  > +		dd->ipath_pioavailregs_dma[i] = cpu_to_le64(val);
>  > +		dd->ipath_pioavailshadow[i] = val;
> 
> This is more than a warning fix, right?  It seems it fixes an
> incorrect value being assigned to pioavailshadow on big endian
> systems.
> 
>  - R.

Correct.
I guess I was fixating on the warning since you pointed it out.




More information about the general mailing list