[ofa-general] Re: [PATCH 2/5] Add an optional test utility 'ibsendtrap'

[Sasha Khapyorsky]

On 15:51 Fri 21 Mar     , Ira Weiny wrote:
> From 9294bf0041e88a077918619d5a93be318075cd74 Mon Sep 17 00:00:00 2001
> From: Ira K. Weiny <weiny2 at llnl.gov>
> Date: Fri, 21 Mar 2008 14:26:05 -0700
> Subject: [PATCH] Add an optional test utility 'ibsendtrap'
> use --enable-test-utils to build this tool
> 
> Signed-off-by: Ira K. Weiny <weiny2 at llnl.gov>

Applied. Thanks. The comment is below.

[snip...]

> diff --git a/infiniband-diags/src/ibsendtrap.c b/infiniband-diags/src/ibsendtrap.c
> new file mode 100644
> index 0000000..ae5069b
> --- /dev/null
> +++ b/infiniband-diags/src/ibsendtrap.c
> @@ -0,0 +1,179 @@
> +/*
> + * Copyright (c) 2008 Lawrence Livermore National Security
> + *
> + * Produced at Lawrence Livermore National Laboratory.
> + * Written by Ira Weiny <weiny2 at llnl.gov>.
> + *
> + * This software is available to you under a choice of one of two
> + * licenses.  You may choose to be licensed under the terms of the GNU
> + * General Public License (GPL) Version 2, available from the file
> + * COPYING in the main directory of this source tree, or the
> + * OpenIB.org BSD license below:
> + *
> + *     Redistribution and use in source and binary forms, with or
> + *     without modification, are permitted provided that the following
> + *     conditions are met:
> + *
> + *      - Redistributions of source code must retain the above
> + *        copyright notice, this list of conditions and the following
> + *        disclaimer.
> + *
> + *      - Redistributions in binary form must reproduce the above
> + *        copyright notice, this list of conditions and the following
> + *        disclaimer in the documentation and/or other materials
> + *        provided with the distribution.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
> + * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
> + * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
> + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> + * SOFTWARE.
> + *
> + */
> +
> +#include <stdio.h>
> +#include <unistd.h>

There should be also stdlib.h for exit() and string.h for strtoul(). I
added this.

Sasha