[ofa-general] Re: [PATCH] opensm/osm_qos_policy.c : set SL for IPoIB broadcast groups

[Or Gerlitz]

Yevgeny Kliteynik wrote:
> Hi Sasha,
>
> QoS manager should set the right SL in the IPoIB broadcast groups
> to enforce the right SL for IPoIB traffic.
>
> At start it seemed to me that it won't work in the following scenario:
>  - IPoIB partition created
>  - IPoIB mcast group created
>  - IPoIB connectivity was established between two ports
>  - SL in the QoS policy file was changed
>  - SM is doing heavy sweep, and setting new SL in the
>    partition and mcast group, but the nodes already have
>    connectivity, so they will continue to transmit on the
>    previous SL
> But then I realized that this scenario will be a problem for any
> communication (not only IPoIB), because as long as clients are not
> issuing new PR request, they will have the old parameters that won't
> be affected by the changes in QoS policy.
>   
Let me understand, when the user changes the QoS policy file, openSM 
reads it on the fly and creates new rules?
> This patch is for ofed_1_3 branch.
>
> Please review and let me know what you think.
>
> Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
>   
Is this the change log comment? please explain what the patch is doing, 
I understand that the text above is the problem statement, not the 
solution..., correct?

Or.