[ofa-general] [PATCH 3/5] drivers/infiniband: test for IS_ERR rather than 0

[Julia Lawall]

From: Julia Lawall <julia at diku.dk>

The function rdma_create_id always returns either a valid pointer or a
value made with ERR_PTR, so its result should be tested with IS_ERR, not
with a test for 0.


The problem was found using the following semantic match.
(http://www.emn.fr/x-info/coccinelle/)

//<smpl>
@a@
expression E, E1;
statement S,S1;
position p;
@@

E = rdma_create_id(...)
... when != E = E1
if at p (E) S else S1

@n@
position a.p;
expression E,E1;
statement S,S1;
@@

E = NULL
... when != E = E1
if at p (E) S else S1

@depends on !n@
expression E;
statement S,S1;
position a.p;
@@

* if at p (E)
  S else S1
//</smpl>

Signed-off-by: Julia Lawall <julia at diku.dk>
---
 drivers/infiniband/core/cma.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -u -p a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
--- a/drivers/infiniband/core/cma.c	2008-03-12 14:13:13.000000000 +0100
+++ b/drivers/infiniband/core/cma.c	2008-03-24 16:10:01.000000000 +0100
@@ -1289,7 +1289,7 @@ static int iw_conn_req_handler(struct iw
 	new_cm_id = rdma_create_id(listen_id->id.event_handler,
 				   listen_id->id.context,
 				   RDMA_PS_TCP);
-	if (!new_cm_id) {
+	if (IS_ERR(new_cm_id)) {
 		ret = -ENOMEM;
 		goto out;
 	}