[ofa-general] Re: [PATCH 3/10] IB/core: Add LSO support

[Eli Cohen]

On Mon, 2008-03-24 at 15:21 -0700, Roland Dreier wrote:
> > @@ -622,7 +624,8 @@ enum ib_wr_opcode {
>  > +	IB_WR_LSO
> 
>  > @@ -630,7 +633,8 @@ enum ib_send_flags {
>  > +	IB_SEND_UDP_LSO         = (1<<5)
> 
> What is this send flag used for?  It doesn't seem to appear anywhere
> else in the patch series and it seems redundant given that you've
> defined a new opcode for LSO send requests.
> 
> I did a quick grep of the OFED 1.3 kernel tree and IB_SEND_UDP_LSO
> only seems to appear once, in the line where it is defined.  So I
> guess it's OK to drop this chunk of the patch?

Yes, it can be removed. Thanks.