[ofa-general] [PATCH 4/10] IB/ipoib: Add LSO support to ipoib

[Or Gerlitz]

Eli Cohen wrote:
> On Sun, 2008-03-23 at 09:33 +0200, Or Gerlitz wrote:
>> is the 60 bytes being a limitation of the connectX HW, the Linux kernel 
>> stack or some "lso spec"?
> It's an implementation decision - I assume that I will never get TSO
> SKBs where the headers exceed 60 bytes.
What does this assumption buys you? do you have to allocate/copy the 
header and you want to be limited to 60 bytes? can you point me to where 
this limitation comes into play over this patch set? is there an 
equivalent design/check in one of the Ethernet drivers supporting LSO?

> It looks like I would get the same effect if I'd used e1000 style though
> I'm not sure which approach is faster. 
I think that the e1000 approach is --much-- more readable, I would go on 
clarity here.
>> shouldn't the tx_dropped counter be incremented here?
> I am not sure. Does every erroneous tx packets imply incrementing the
> drop counter too?
I think so, but you can look around in ipoib or other driver or get more 
opinions.

Or.