[ofa-general] Re: [PATCH 4/4] opensm: remove not used osm_log_printf() function

[Hal Rosenstock]

On Wed, 2008-03-26 at 17:27 +0000, Sasha Khapyorsky wrote:
> Remove not used anymore osm_log_printf() function from osm_log. Update
> libopensm library version.

Shouldn't this be deprecated for one library version prior to removing ?

> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> ---
>  opensm/include/opensm/osm_log.h |    2 --
>  opensm/opensm/libopensm.map     |    1 -
>  opensm/opensm/libopensm.ver     |    2 +-
>  opensm/opensm/osm_log.c         |   19 -------------------
>  4 files changed, 1 insertions(+), 23 deletions(-)
> 
> diff --git a/opensm/include/opensm/osm_log.h b/opensm/include/opensm/osm_log.h
> index dd63dc4..48fb15e 100644
> --- a/opensm/include/opensm/osm_log.h
> +++ b/opensm/include/opensm/osm_log.h
> @@ -389,8 +389,6 @@ osm_log_is_active(IN const osm_log_t * const p_log,
>  *	osm_log_destroy
>  *********/
>  
> -extern int osm_log_printf(osm_log_t * p_log, osm_log_level_t level,
> -			  const char *fmt, ...) STRICT_OSM_LOG_FORMAT;
>  extern void osm_log_msg_box(osm_log_t *log, osm_log_level_t level,
>  			    const char *func_name, const char *msg);
>  extern void osm_log_raw(IN osm_log_t * const p_log,
> diff --git a/opensm/opensm/libopensm.map b/opensm/opensm/libopensm.map
> index 1d574bc..759a4e8 100644
> --- a/opensm/opensm/libopensm.map
> +++ b/opensm/opensm/libopensm.map
> @@ -1,7 +1,6 @@
>  OPENSM_1.5 {
>  	global:
>  		osm_log;
> -		osm_log_printf;
>  		osm_log_msg_box;
>  		osm_is_debug;
>  		osm_log_init;
> diff --git a/opensm/opensm/libopensm.ver b/opensm/opensm/libopensm.ver
> index c00a3a9..3324b1a 100644
> --- a/opensm/opensm/libopensm.ver
> +++ b/opensm/opensm/libopensm.ver
> @@ -6,4 +6,4 @@
>  # API_REV - advance on any added API
>  # RUNNING_REV - advance any change to the vendor files
>  # AGE - number of backward versions the API still supports
> -LIBVERSION=2:0:1
> +LIBVERSION=2:1:0
> diff --git a/opensm/opensm/osm_log.c b/opensm/opensm/osm_log.c
> index b5b4bd9..727aabc 100644
> --- a/opensm/opensm/osm_log.c
> +++ b/opensm/opensm/osm_log.c
> @@ -106,25 +106,6 @@ static void truncate_log_file(osm_log_t * const p_log)
>  }
>  #endif				/* ndef WIN32 */
>  
> -int osm_log_printf(osm_log_t * p_log, osm_log_level_t level,
> -		   const char *fmt, ...)
> -{
> -	va_list args;
> -	int ret;
> -
> -	if (!(p_log->level & level))
> -		return 0;
> -
> -	va_start(args, fmt);
> -	ret = vfprintf(stdout, fmt, args);
> -	va_end(args);
> -
> -	if (p_log->flush || level & OSM_LOG_ERROR)
> -		fflush(stdout);
> -
> -	return ret;
> -}
> -
>  void
>  osm_log(IN osm_log_t * const p_log,
>  	IN const osm_log_level_t verbosity, IN const char *p_str, ...)