[ofa-general] Re: [PATCH 4/4] opensm: remove not used osm_log_printf() function

[Hal Rosenstock]

On Thu, 2008-03-27 at 00:41 +0000, Sasha Khapyorsky wrote:
> On 11:28 Wed 26 Mar     , Hal Rosenstock wrote:
> > 
> > Because it was published as a global API and something outside might be
> > using it. It's not necessarily just for internal consumers.
> 
> It was recent enough

It's been around since 11/06 (svn days) so that's several releases:

commit 77d05cd79a1cad790aa7766331dcf4f2d8bddc4e
Author: Sasha Khapyorsky <sashak at voltaire.com>
Date:   Fri Nov 3 11:55:58 2006 +0000

    r10053: OpenSM: Remove obsolete p_report_buf
    
    This removes obsolete now shared sm->p_report_buf buffer and cleans
    up related code. And also introduces new log function osm_log_printf()
    which currently trivially sends formatted output to stdout.
    
    Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>

> and almost useless function so I'm very skeptical it was used anywhere.

Yes, it's trivial.

> And of course I checked publicly available places (like ibutils).
> 
> If you like I can depreciate this for some period of time, but personally
> don't think it is needed for anybody.

This issue was initially the procedural issue of removing a public API
without deprecation warning for a release which is the norm.

Personally I don't care about this specific API.

-- Hal

> Sasha
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general