[ofa-general] Re: [PATCH 4/10 v1] IB/ipoib: Add LSO support to ipoib

[Roland Dreier]

OK, applied, but:

 > +	if (!skb_is_gso(skb)) {
 > +		if (unlikely(skb->len > priv->mcast_mtu + IPOIB_ENCAP_LEN)) {
 > +			ipoib_warn(priv, "packet len %d (> %d) too long to send, dropping\n",
 > +				   skb->len, priv->mcast_mtu + IPOIB_ENCAP_LEN);

can this ever really happen?  Is it worth having code to check it?
presumably we'll just get a local length error on the send and find
out anyway.

 > +		if (unlikely(!skb_pull(skb, hlen))) {
 > +			ipoib_warn(priv, "linear data too small\n");
 > +			goto drop;
 > +		}

similarly can this ever trigger?

 - R.