[ofa-general] [RFC][PATCH] opensm/configure.in: improve readability of configured config files

[Yevgeny Kliteynik]

Hi Sasha,

Sasha Khapyorsky wrote:
> When ./configure script is executed it will show the values which are
> used for those config files, like this:
>
> checking for --with-opensm-conf-sub-dir... opensm
> checking for --with-node-name-map ... ib-node-name-map
> checking for --with-partitions-conf... partitions.conf
> checking for --with-qos-policy-conf... qos-policy.conf
>
> And not just that it was or wasn't redefined from its default values
> (checking for --with-partitions-conf... no , etc).
>
> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> ---
>
> Another ideas? Maybe to print full path at least for
> opensm-conf-sub-dir, like: /usr/local/etc/opensm?
>   

Actually, printing full path for opensm-conf-sub-dir is a great idea!
Moreover, I wouldn't mind seeing the full path for all the config files,
but that would be less important than the config dir.

-- Yevgeny


> Sasha
>
>  opensm/configure.in |   12 ++++--------
>  1 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/opensm/configure.in b/opensm/configure.in
> index a5b7c5a..d88bfd4 100644
> --- a/opensm/configure.in
> +++ b/opensm/configure.in
> @@ -92,12 +92,11 @@ AC_ARG_WITH(opensm-conf-sub-dir,
>      no)
>          ;;
>      *)
> -        withopensmconfsubdir=yes
>          OPENSM_CONF_SUB_DIR=$withval
>          ;;
>      esac ]
>  )
> -AC_MSG_RESULT(${withopensmconfsubdir=no})
> +AC_MSG_RESULT($OPENSM_CONF_SUB_DIR)
>  AC_SUBST(OPENSM_CONF_SUB_DIR)
>  
>  dnl Set up <sysconfdir>/opensm config dir.
> @@ -120,12 +119,11 @@ AC_ARG_WITH(node-name-map,
>      no)
>          ;;
>      *)
> -        withnodenamemap=yes
>          NODENAMEMAPFILE=$withval
>          ;;
>      esac ]
>  )
> -AC_MSG_RESULT(${withnodenamemap=no})
> +AC_MSG_RESULT($NODENAMEMAPFILE)
>  AC_DEFINE_UNQUOTED(HAVE_DEFAULT_NODENAME_MAP,
>  	["$CONF_DIR/$NODENAMEMAPFILE"],
>  	[Define a default node name map file])
> @@ -141,12 +139,11 @@ AC_ARG_WITH(partitions-conf,
>      no)
>          ;;
>      *)
> -        withpartitionsconf=yes
>          PARTITION_CONFIG_FILE=$withval
>          ;;
>      esac ]
>  )
> -AC_MSG_RESULT(${withpartitionsconf=no})
> +AC_MSG_RESULT($PARTITION_CONFIG_FILE)
>  AC_DEFINE_UNQUOTED(HAVE_DEFAULT_PARTITION_CONFIG_FILE,
>  	["$CONF_DIR/$PARTITION_CONFIG_FILE"],
>  	[Define a Partition config file])
> @@ -162,12 +159,11 @@ AC_ARG_WITH(qos-policy-conf,
>      no)
>          ;;
>      *)
> -        withqospolicyconf=yes
>          QOS_POLICY_FILE=$withval
>          ;;
>      esac ]
>  )
> -AC_MSG_RESULT(${withqospolicyconf=no})
> +AC_MSG_RESULT($QOS_POLICY_FILE)
>  AC_DEFINE_UNQUOTED(HAVE_DEFAULT_QOS_POLICY_FILE,
>  	["$CONF_DIR/$QOS_POLICY_FILE"],
>  	[Define a QOS policy config file])
>