[ofa-general] Re: [PATCH 1/2] IB/iSER: Do not add unsolicited data offset to VA in iSER header

[Eli Dorfman]

On Sun, Apr 27, 2008 at 3:53 PM, Eli Dorfman <dorfman.eli at gmail.com> wrote:
> iSER initiator sends a VA (in the iSER header) which includes
>  an offset for the unsolicited data (which is wrong according to the spec).
>
>  Signed-off-by: Eli Dorfman <elid at voltaire.com>
>  Signed-off-by: Erez Zilber <erezz at voltaire.com>
>  ---
>   drivers/infiniband/ulp/iser/iser_initiator.c |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
>  diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c
>  b/drivers/infiniband/ulp/iser/iser_initiator.c
>  index 08dc81c..5c2bbc6 100644
>  --- a/drivers/infiniband/ulp/iser/iser_initiator.c
>  +++ b/drivers/infiniband/ulp/iser/iser_initiator.c
>  @@ -154,12 +154,12 @@ iser_prepare_write_cmd(struct iscsi_cmd_task *ctask,
>         if (unsol_sz < edtl) {
>                 hdr->flags     |= ISER_WSV;
>                 hdr->write_stag = cpu_to_be32(regd_buf->reg.rkey);
>  -               hdr->write_va   = cpu_to_be64(regd_buf->reg.va + unsol_sz);
>  +               hdr->write_va   = cpu_to_be64(regd_buf->reg.va);
>
>                 iser_dbg("Cmd itt:%d, WRITE tags, RKEY:%#.4X "
>  -                        "VA:%#llX + unsol:%d\n",
>  +                        "VA:%#llX\n",
>                          ctask->itt, regd_buf->reg.rkey,
>  -                        (unsigned long long)regd_buf->reg.va, unsol_sz);
>  +                        (unsigned long long)regd_buf->reg.va);
>         }
>
>         if (imm_sz > 0) {
>  --
>  1.5.5
>

Please do not apply this patch until we decide how to sync this with
the target side.

Thanks,
Eli