[ofa-general] Re: [PATCH] ibsim/sim.h: Fix NodeDescription size

Sasha Khapyorsky sashak at voltaire.com
Mon May 12 11:41:38 PDT 2008


On 14:01 Sun 04 May     , Hal Rosenstock wrote:
> ibsim/sim.h: Fix NodeDescription size so can have maximum size
> NodeDescription per IBA spec rather than truncating them
> 
> Signed-off-by: Hal Rosenstock <hal at xsigo.com>
> 
> diff --git a/ibsim/sim.h b/ibsim/sim.h
> index bea136a..dbf1220 100644
> --- a/ibsim/sim.h
> +++ b/ibsim/sim.h
> @@ -67,7 +67,7 @@
>  
>  #define NODEIDBASE	20
>  #define NODEPREFIX	20
> -#define NODEIDLEN	(NODEIDBASE+NODEPREFIX+1)
> +#define NODEIDLEN	65
>  #define ALIASLEN 	40

nodeid filed in struct Node still have length 64, so it looks that using
NODEIDLEN value larger than this introduces overflow. I think bigger
change is needed there.

Sasha



More information about the general mailing list