[ofa-general] Re: [PATCH] ibsim/sim.h: Fix NodeDescription size

[Sasha Khapyorsky]

On 12:20 Mon 12 May     , Hal Rosenstock wrote:
> > > diff --git a/ibsim/sim.h b/ibsim/sim.h
> > > index bea136a..0bf14fd 100644
> > > --- a/ibsim/sim.h
> > > +++ b/ibsim/sim.h
> > > @@ -65,9 +65,8 @@
> > >  #define        DEFAULT_LINKWIDTH       LINKWIDTH_4x
> > >  #define DEFAULT_LINKSPEED      LINKSPEED_SDR
> > >  
> > > -#define NODEIDBASE     20
> > >  #define NODEPREFIX     20
> 
> I think this can now be eliminated as the only use was in NODEIDLEN.

Agree (missed this).

> > > -#define NODEIDLEN      (NODEIDBASE+NODEPREFIX+1)
> > > +#define NODEIDLEN      64
> > >  #define ALIASLEN       40
> > 
> > It is likely will prevent overflow, but will potentially truncate last
> > NodeDesc character due to string NULL terminator. What about something
> > like below?
> 
> Thanks. This seems to work for my usage but not sure about some of the
> other concatenated names and whether it accomodates those other usages
> which I don't fully understand.

There are no changes in the parser, just filed sizes handling.

Sasha