[ofa-general] [RFC PATCH 3/4] rdma/cma: add high availability mode attribute to IDs

[Roland Dreier]

 > +enum  rdma_ha_mode {
 > +	RDMA_ALIGN_WITH_NETDEVICE = 1
 > +};

 > +int rdma_set_high_availability_mode(struct rdma_cm_id *id, enum rdma_ha_mode mode)

this seems like overengineering to me... given there are no other modes,
you are adding an elaborate NOP.  (Nothing looks at ha_mode)

Do you have plans for other modes?

 >  	u8			srq;
 >  	u8			tos;
 > +	enum rdma_ha_mode	ha_mode;

Side note -- you're wasting two bytes here because of alignment.