[ofa-general] Re: [PATCH 06/13] QLogic VNIC: IB core stack interaction
Roland Dreier
rdreier at cisco.com
Tue May 13 13:40:52 PDT 2008
> +#include <rdma/ib_cache.h>
> + ret = ib_find_cached_pkey(viport_config->ibdev,
> + viport_config->port,
> + be16_to_cpu(viport_config->path_info.path.
> + pkey),
> + &attr->pkey_index);
I think this can just be replaced with ib_find_pkey()... there is a call
to kmalloc(... GFP_KERNEL) just a couple of lines about, so you are in a
context where sleeping is allowed. As I said before we want to get rid
of the caching infrastructure so please don't add new users.
More information about the general
mailing list