[ofa-general] [PATCH] mlx4: implement MOD_STAT_CFG command to use for changing ConnectX page size

[Jack Morgenstein]

On Monday 19 May 2008 00:45, Roland Dreier wrote:
> [Adding list cc]
> 
> > +static int mlx4_log_pg_sz = 0;
> > +module_param(mlx4_log_pg_sz, int, 0444);
> > +MODULE_PARM_DESC(mlx4_log_pg_sz,
> > +                "set FW log system min page size (0 gets native FW min. default=0)");
> 
> Why do we need this module parameter?  When would someone set it to anything
> other than 0?

This is in case at some installation, the administrator wishes to use the legacy device page size
of 12, for example.  Having a module parameter enables such tweaking to be done painlessly.

> 
> > -       return __mlx4_cmd(dev, in_param, out_param, 1, in_modifier,
> > +       return __mlx4_cmd(dev, in_param, out_param, out_param ? 1 : 0, in_modifier,
> >                          op_modifier, op, timeout);
> 
> I don't see any call to mlx4_cmd_imm in this patch -- why is this change needed?
>
You're right, this was just a hold-over from the first version of the patch (which used
immediate data instead of the mailbox).

- Jack