[ofa-general] Re: [PATCH 10/13] QLogic VNIC: Driver Statistics collection

[Ramachandra K]

Roland,

On Fri, May 16, 2008 at 4:03 AM, Roland Dreier <rdreier at cisco.com> wrote:
>  > +#else       /*CONFIG_INIFINIBAND_VNIC_STATS*/
>  > +
>  > +static inline void vnic_connected_stats(struct vnic *vnic)
>  > +{
>  > +    ;
>  > +}
>
> there are an awful lot of stubs here.  Do you really expect anyone to
> set CONFIG_INFINIBAND_QLGC_VNIC_STATS=n?

Sorry, missed this comment from the first round of review. Yes, the default
behavior we want is to disable the statistics collection as some of the
statistics collection is in the data transfer path and hence this code
can add overheads. These statistics are more for performance debugging/tuning.

Regards,
Ram