[ofa-general] saquery port problems

Sasha Khapyorsky sashak at voltaire.com
Thu May 22 00:37:03 PDT 2008


Hi Matthias,

On 16:48 Wed 21 May     , Matthias Blankenhaus wrote:
> I have a patch that fixes the problem:
> 
> diff -Narpu infiniband-diags-1.3.6.vanilla/src/saquery.c my/src/saquery.c
> --- infiniband-diags-1.3.6.vanilla/src/saquery.c        2008-02-28 
> 00:58:36.000000000 -0800
> +++ my/src/saquery.c    2008-05-21 16:08:19.583221794 -0700
> @@ -1304,13 +1304,13 @@ get_bind_handle(void)
>                         ca_name_index++;
>                 if (sa_port_num && sa_port_num != attr_array[i].port_num)
>                         continue;
> -               if (sa_hca_name && i == 0)
> -                       continue;
>                 if (sa_hca_name
>                  && strcmp(sa_hca_name, vendor->ca_names[ca_name_index]) != 0)
>                         continue;
> -               if (attr_array[i].link_state == IB_LINK_ACTIVE)
> +               if (attr_array[i].link_state == IB_LINK_ACTIVE) {
>                         port_guid = attr_array[i].port_guid;
> +                       break;
> +                }
>         }
> 
> 
> I have tested it and it solves the problem.
> 
> Does this look ok ?

Yes, this looks correct. Thanks for fixing this. I just will need your
'Signed-off-by:' line in order to apply the patch.

Sasha



More information about the general mailing list