[ofa-general] Re: [PATCH v2 12/13] QLogic VNIC: Driver Kconfig and Makefile.

[Ramachandra K]

Roland,

On Mon, May 26, 2008 at 4:13 AM, Roland Dreier <rdreier at cisco.com> wrote:
>  > +config INFINIBAND_QLGC_VNIC_DEBUG
>  > +    bool "QLogic VNIC Verbose debugging"
>  > +    depends on INFINIBAND_QLGC_VNIC
>  > +    default n
>  > +    ---help---
>  > +      This option causes verbose debugging code to be compiled
>  > +      into the QLogic VNIC driver.  The output can be turned on via the
>  > +      vnic_debug module parameter.
>
> I think I mentioned this before, but... if you default this option to
> 'n', then all distributions will build your module with the option off.
> And if someone is having problems, they will be forced to rebuild their
> kernel to get debug output, which is a heavy burden for most users.

The debugging code is always compiled in and is controlled
at run time through vnic_debug module parameter.
INFINIBAND_QLGC_VNIC_DEBUG config option only controls verbose debugging
which adds some extra information in the debug statements (file name,
line number)
which we typically use for debug builds of the driver.  Even if this option is
set to 'n', users can still get all debug messages from the driver by using the
vnic_debug module parameter.

Regards,
Ram