***SPAM*** Re: [ofa-general] [PATCH] opensm: fix iser service-id used for SL assignment

[Hal Rosenstock]

On Thu, Nov 6, 2008 at 7:57 AM, Or Gerlitz <ogerlitz at voltaire.com> wrote:
> RFC3720 says:
>
> The well-known user TCP port number for iSCSI connections assigned by IANA is 3260
> and this is the default iSCSI port. Implementations needing a system TCP port number
> may use port 860, the port assigned by IANA as the iSCSI system port; however in
> order to use port 860, it MUST be explicitly specified - implementations MUST NOT
> default to use of port 860, as 3260 is the only allowed default.
>
> Hence the SID used by iser is 0x0000000001060CBC and not 0x000000000106035C
>
> Signed-off-by: Or Gerlitz  <ogerlitz at voltaire.com>
> Signed-off-by: Eli Dorfman <elid at voltaire.com>
>
> Index: opensm-3.2.2/doc/QoS_management_in_OpenSM.txt
> ===================================================================
> --- opensm-3.2.2.orig/doc/QoS_management_in_OpenSM.txt
> +++ opensm-3.2.2/doc/QoS_management_in_OpenSM.txt
> @@ -378,12 +378,12 @@ equivalent:
>
>  6.4  iSER
>  Similar to RDS, iSER query is matched by Service ID, where the the Service ID
> -is also 0x000000000106PPPP. Default port number for iSER is 0x035C, which makes
> -a default Service-ID 0x000000000106035C. The following two match rules are
> +is also 0x000000000106PPPP. Default port number for iSER is 0x0CBC, which makes
> +a default Service-ID 0x0000000001060CBC.

Should some mention of the prestandard port number be mentioned here
for backward compatibility ?

>The following two match rules are
>  equivalent:
>
>     iser                               : <SL>
> -    any, service-id 0x000000000106035C : <SL>
> +    any, service-id 0x0000000001060CBC : <SL>
>
>  6.5  SRP
>  Service ID for SRP varies from storage vendor to vendor, thus SRP query is
> Index: opensm-3.2.2/include/opensm/osm_qos_policy.h
> ===================================================================
> --- opensm-3.2.2.orig/include/opensm/osm_qos_policy.h
> +++ opensm-3.2.2/include/opensm/osm_qos_policy.h
> @@ -58,7 +58,7 @@
>  #define OSM_QOS_POLICY_ULP_RDS_SERVICE_ID   0x0000000001060000ULL
>  #define OSM_QOS_POLICY_ULP_RDS_PORT         0x48CA
>  #define OSM_QOS_POLICY_ULP_ISER_SERVICE_ID  0x0000000001060000ULL
> -#define OSM_QOS_POLICY_ULP_ISER_PORT        0x035C
> +#define OSM_QOS_POLICY_ULP_ISER_PORT        0x0CBC
>
>  #define OSM_QOS_POLICY_NODE_TYPE_CA        (((uint8_t)1)<<IB_NODE_TYPE_CA)
>  #define OSM_QOS_POLICY_NODE_TYPE_SWITCH    (((uint8_t)1)<<IB_NODE_TYPE_SWITCH)
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>