[ofa-general] Re: [PATCH] opensm: fix iser service-id used for SL assignment

[Or Gerlitz]

On Thu, 6 Nov 2008, Or Gerlitz wrote:
> The well-known user TCP port number for iSCSI connections assigned by IANA is 3260
> and this is the default iSCSI port. Implementations needing a system TCP port number
> may use port 860, the port assigned by IANA as the iSCSI system port; however in
> order to use port 860, it MUST be explicitly specified - implementations MUST NOT
> default to use of port 860, as 3260 is the only allowed default.
>
> Hence the SID used by iser is 0x0000000001060CBC and not 0x000000000106035C

> Index: opensm-3.2.2/include/opensm/osm_qos_policy.h
> ===================================================================
> --- opensm-3.2.2.orig/include/opensm/osm_qos_policy.h
> +++ opensm-3.2.2/include/opensm/osm_qos_policy.h
> @@ -58,7 +58,7 @@
>  #define OSM_QOS_POLICY_ULP_RDS_SERVICE_ID   0x0000000001060000ULL
>  #define OSM_QOS_POLICY_ULP_RDS_PORT         0x48CA
>  #define OSM_QOS_POLICY_ULP_ISER_SERVICE_ID  0x0000000001060000ULL
> -#define OSM_QOS_POLICY_ULP_ISER_PORT        0x035C
> +#define OSM_QOS_POLICY_ULP_ISER_PORT        0x0CBC

BTW - while doing this fix, I noted that the port assumed by opensm for RDS is 18634
(0x48CA) which is the ones used in the rds code deployed in ofed 1.3.x, where the rds
code based deployed into ofed 1.4.y uses port 18635

Andy, Rick, can you guys revert to 18634 to make things simpler wrt RDS/QoS configuration?

Or.